Skip to content

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Sep 16, 2025

  • Improves how views are created by dropping createFragment command call
  • Improves how views are disposed and fragments removed on Android platform
  • Improves null checking for both platforms

Fixes #309

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

Copy link
Member

@caio1985 caio1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@illuminati1911 illuminati1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

-  add better null checks for Android and iOS views
@jokerttu jokerttu force-pushed the fix/fragment-dispose-issues-on-android branch from f9d7c4a to e97e48a Compare September 17, 2025 07:19
@jokerttu jokerttu marked this pull request as draft September 17, 2025 12:49
@jokerttu
Copy link
Contributor Author

Converted as draft, as this do not solve all issues just yet.
Fragment creation needs to be updated so that it won't crash if view is not drawn to view hierarchy.

@jokerttu jokerttu marked this pull request as ready for review September 19, 2025 12:01
@jokerttu jokerttu changed the title fix: view disposal issue fix: view lifecycle issue Sep 19, 2025
@jokerttu jokerttu merged commit 2922fc6 into main Sep 19, 2025
12 checks passed
@jokerttu jokerttu deleted the fix/fragment-dispose-issues-on-android branch October 9, 2025 06:57
Spice-Z added a commit to Spice-Z/react-native-navigation-sdk that referenced this pull request Oct 16, 2025
custom marker and animation

text marker

chore: improve example app layout for latest ios versions (googlemaps#474)

fix: view lifecycle issue (googlemaps#473)

chore(main): release 0.10.3 (googlemaps#476)

feat: upgrade iOS SDK version to 10.4.0 (googlemaps#482)

feat!: upgrade Android SDK to 7.0.0 (googlemaps#481)

Breaking change: Adds new enum value RouteStatus.DUPLICATE_WAYPOINTS_ERROR

docs: typedoc deprecation for showStopSigns and showTrafficLights (googlemaps#486)

revert: "feat: upgrade iOS SDK version to 10.4.0 (googlemaps#482)" (googlemaps#488)

chore(main): release 0.11.0 (googlemaps#489)

remove pulse

remove moveMarker

remove color support from addMarker

recover impor

improve text pin

add same capability on iOS

fix color issue on iOS

refactor moveMarker and addTextMarker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The specified child already has a parent. You must call removeView() on the child's parent first.

3 participants